2796
88%

Ran 12 Mar 2018 09:46PM UTC

Jobs 5

Files 76

Run time 4min

Badge

Embed ▾

pending completion

Build # 2796

Build Type

push

travis-ci

Committed by

elhigu

Commit Message

feat: countDistinct with multiple columns (#2449)

* test(QueryBuilder): add test for countDistinct with multiple columns

* test: add integration test for countDistinct with multiple columns

* feat(QueryBuilder): support multiple columns for countDistinct

* feat(QueryBuilder): support object alias notation for aggregate methods

i.e. `count`, `countDistinct`, `max`, `min`, `avg`, `avgDistinct`, `sum`, `sumDistinct`

* test: fix integration tests for countDistinct

* fix(QueryBuilder): fix countDistinct formatting with multiple columns

* refactor(QueryBuilder): add _aggregate from helpers

* fix(QueryCompiler): only use parens for distinct with postgres

* test(QueryBuilder): remove unsupported tests

for count with multiple distinct columns in databases where this is
not supported

* refactor(QueryBuilder): improve readability

Coverage Stats

2198 of 2974 branches covered (73.91%)

5218 of 5863 relevant lines covered (89.0%)

2934.99 hits per line

Coverage Regressions

Lines	Coverage	File
14	100.0	lib/query/compiler.js
8	100.0	lib/query/builder.js
4	100.0	lib/dialects/postgres/query/compiler.js

Jobs

ID	Job ID	Ran	Coverage
1	2796.1 (TEST_ORACLEDB=true DB="maria mysql mysql2 postgres sqlite3 oracledb" CXX=g++-4.8 KNEX_TEST_TIMEOUT=60000 ORACLE_HOME=/u01/app/oracle/product/11.2.0/xe ORACLE_SID=XE OCI_LIB_DIR=/u01/app/oracle/product/11.2.0/xe/lib LD_LIBRARY_PATH=/u01/app/oracle/product/11.2.0/xe/lib)	12 Mar 2018 09:49PM UTC	89.0	Travis Job 2796.1
2	2796.2 (TEST_ORACLEDB=true DB="maria mysql mysql2 postgres sqlite3 oracledb" CXX=g++-4.8 KNEX_TEST_TIMEOUT=60000 ORACLE_HOME=/u01/app/oracle/product/11.2.0/xe ORACLE_SID=XE OCI_LIB_DIR=/u01/app/oracle/product/11.2.0/xe/lib LD_LIBRARY_PATH=/u01/app/oracle/product/11.2.0/xe/lib)	12 Mar 2018 09:48PM UTC	89.0	Travis Job 2796.2
3	2796.3 (TEST_ORACLEDB=true DB="maria mysql mysql2 postgres sqlite3 oracledb" CXX=g++-4.8 KNEX_TEST_TIMEOUT=60000 ORACLE_HOME=/u01/app/oracle/product/11.2.0/xe ORACLE_SID=XE OCI_LIB_DIR=/u01/app/oracle/product/11.2.0/xe/lib LD_LIBRARY_PATH=/u01/app/oracle/product/11.2.0/xe/lib)	12 Mar 2018 09:50PM UTC	89.0	Travis Job 2796.3
4	2796.4 (DB="maria mysql mysql2 postgres sqlite3" CXX=g++-4.8 KNEX_TEST_TIMEOUT=60000)	12 Mar 2018 09:46PM UTC	84.62	Travis Job 2796.4
5	2796.5 (DB="maria mysql mysql2 postgres sqlite3" CXX=g++-4.8 KNEX_TEST_TIMEOUT=60000)	12 Mar 2018 09:46PM UTC	84.62	Travis Job 2796.5

Source Files on build 2796

Detailed source file information is not available for this build.

tgriesser / knex / 2796
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 2796

tgriesser / knex / 2796 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Coverage Regressions

Jobs

Source Files on build 2796

tgriesser / knex / 2796
88%

README BADGES
x