PHPCompatibility / PHPCompatibility / 1555
76%
develop: 98%

LAST BUILD BRANCH: feature/new-newyieldfromcomment-sniff
DEFAULT BRANCH: develop
Ran
Jobs 5
Files 67
Run time 16min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
1555

Pull #610

travis-ci

web-flow 
Sniff: add three utility methods to handle number recognition

These methods can be used to determine if variable assignments, function call parameters or array values would be regarded as a (positive/negative) number by PHP.

The `isNumber()` method is used to determine whether something would be regarded as a number by PHP.
This method takes type juggling from string and boolean to integer/float into account.

The method will return `false` if something isn't a number as well as when it couldn't be reliably determined, so should only be used for testing whether something definitely *is* a number (well, that is _would be regarded as a number by PHP_).

The method will return `false` when it encounters calculations, even when all parts of the calculation are numbers. Handling this even better, is something which could possibly be added later (in a future PR). For now, number recognition will already be greatly improved when using these utility methods.

The additional utility methods `isPositiveNumber()` and `isNegativeNumber()` are mostly there to prevent duplicate code in individual sniffs.

Includes extensive unit tests.

N.B.: There are two new sniffs upcoming in which these methods will be used, aside from the bugfix for the negative bitshift sniff.
Pull Request #610: Sniff: add three utility methods to handle number recognition

2624 of 2707 relevant lines covered (96.93%)

29.0 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
1
95.24
 0.0% PHPCompatibility/Sniffs/PHP/InternalInterfacesSniff.php
1
100.0
 0.0% PHPCompatibility/Sniffs/PHP/NewAnonymousClassesSniff.php
1
100.0
 0.0% PHPCompatibility/Sniffs/PHP/NewReturnTypeDeclarationsSniff.php
1
98.04
 0.0% PHPCompatibility/Sniffs/PHP/NonStaticMagicMethodsSniff.php
1
96.23
 0.0% PHPCompatibility/Sniffs/PHP/ReservedFunctionNamesSniff.php
2
97.44
 0.0% PHPCompatibility/Sniffs/PHP/NewGroupUseDeclarationsSniff.php
2
98.48
 0.0% PHPCompatibility/Sniffs/PHP/NewNullableTypesSniff.php
3
97.41
 0.0% PHPCompatibility/Sniffs/PHP/ForbiddenNamesSniff.php
3
96.91
 0.0% PHPCompatibility/Sniffs/PHP/NewExecutionDirectivesSniff.php
3
98.51
 0.0% PHPCompatibility/Sniffs/PHP/NewKeywordsSniff.php
3
98.61
 0.0% PHPCompatibility/Sniffs/PHP/ValidIntegersSniff.php
4
98.25
 0.0% PHPCompatibility/Sniffs/PHP/NewClassesSniff.php
5
96.88
 0.0% PHPCompatibility/Sniffs/PHP/NewInterfacesSniff.php
6
92.42
 0.0% PHPCompatibility/Sniffs/PHP/RemovedAlternativePHPTagsSniff.php
7
96.23
 0.0% PHPCompatibility/Sniffs/PHP/NewLanguageConstructsSniff.php
8
97.67
 0.0% PHPCompatibility/Sniffs/PHP/RemovedExtensionsSniff.php
16
92.55
 0.0% PHPCompatibility/Sniffs/PHP/ForbiddenNamesAsDeclaredSniff.php
Jobs
ID Job ID Ran Files Coverage
10 1555.10 (PHPCS_VERSION=">=1.5.1,<2.0" COVERALLS_VERSION="^2.0") 67
93.77
 Travis Job 1555.10
11 1555.11 (PHPCS_VERSION=">=1.5.1,<2.0" COVERALLS_VERSION="^1.0" PHPUNIT_VERSION="~4.5") 67
94.5
 Travis Job 1555.11
12 1555.12 (PHPCS_VERSION=">=2.0,<3.0" LINT=1 COVERALLS_VERSION="^1.0" PHPUNIT_VERSION="~4.5") 67
93.67
 Travis Job 1555.12
15 1555.15 (PHPCS_VERSION="dev-master" LINT=1 COVERALLS_VERSION="^1.0") 67
93.67
 Travis Job 1555.15
20 1555.20 (PHPCS_VERSION="2.3.*" COVERALLS_VERSION="^2.0") 67
93.46
 Travis Job 1555.20
Source Files on build 1555
Coverage ∆ File Lines Relevant Covered Missed Hits/Line