17
72%

Ran 10 Mar 2018 02:08PM CUT

Jobs 1

Files 392

Run time 20s

Badge

Embed ▾

pending completion

Build # 17

Build Type

push

jenkins

Committed by

sijie

Commit Message

Disable using v2 decoder to decode v3 response if usingV2WireProtocol is enabled and handle unknown op in v2 request decoder

Descriptions of the changes in this PR:

*Problem*

- response decoder should use whatever protocol that request is using to decode the response. otherwise it is making wrong assumption on response protocol.
- v2 request decoder doesn't handle unknown op correctly, which will cause netty double-release bytebuf

*Solution*

- make sure response decoder respect the protocol that client is using for sending requests
- v2 request decoder should throw exceptions when fail to decode unknown request

Related issues: #198

Author: Sijie Guo <sijie@apache.org>

Reviewers: Ivan Kelly <ivank@apache.org>, Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>, Matteo Merli <mmerli@apache.org>

This closes #1240 from sijie/bookkeeper_fix_bytebuf_issues

Run Details

22825 of 31352 relevant lines covered (72.8%)

0.73 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	17.1	10 Mar 2018 02:08PM CUT	0	72.8

apache / bookkeeper / 17
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 17

apache / bookkeeper / 17 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 17

apache / bookkeeper / 17
72%

README BADGES
x