1961
5%

Ran 10 Mar 2018 09:26AM UTC

Jobs 3

Files 95

Run time 4min

Badge

Embed ▾

pending completion

Build # 1961

Build Type

Pull #414

travis-ci

Committed by

web-flow

Commit Message

Stop raising prometheus error metric on setup build failure

We used to increment a prometheus error counter whenever build setup
failed. We did this because a failure in build setup used to kill the
slave process. We fixed that in #377. Incrementing the prometheus
counter is now unnecessary noise.

Pull Request Pull Request #414: Stop raising prometheus error metric on setup build failure

Run Details

1 of 1 new or added line in 1 file covered. (100.0%)

3212 of 4104 relevant lines covered (78.27%)

0.82 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	77.7	0.52%	app/master/cluster_master.py

Uncovered Existing Lines

Lines	Coverage	∆	File
3	50.0	0.0%	app/util/conf/deploy_config_loader.py
3	50.0	0.0%	app/util/conf/stop_config_loader.py
3	42.86	0.0%	app/util/fs.py
3	100.0	0.0%	app/util/session_id.py
3	60.0	0.0%	app/web_framework/cluster_application.py
5	66.67	0.0%	app/common/build_artifact.py
5	83.33	0.0%	app/subcommands/subcommand.py
6	35.29	0.0%	app/deployment/deploy_target.py
6	100.0	0.0%	app/master/atom_grouper.py
6	37.5	0.0%	app/subcommands/shutdown_subcommand.py
7	100.0	0.0%	app/util/safe_thread.py
8	100.0	0.0%	app/util/shell/shell_client_factory.py
10	76.92	0.0%	app/deployment/remote_service.py
10	100.0	0.0%	app/deployment/remote_slave_service.py
10	100.0	0.0%	app/util/pagination.py
11	44.0	0.0%	app/util/conf/config_file.py
11	84.62	0.0%	app/util/poll.py
11	100.0	0.0%	app/util/singleton.py
11	100.0	0.0%	app/util/single_use_coin.py
12	100.0	0.0%	app/util/conf/configuration.py
13	100.0	0.0%	app/common/cluster_service.py
13	58.97	0.0%	app/util/process_utils.py
13	100.0	0.0%	app/util/url_builder.py
13	92.86	0.0%	app/util/util.py
15	68.18	0.0%	app/master/build_request.py
15	68.75	0.0%	app/util/log.py
16	100.0	0.0%	app/master/atom.py
16	100.0	0.0%	app/util/app_info.py
16	100.0	0.0%	app/util/counter.py
18	90.0	0.0%	app/master/build_scheduler_pool.py
19	73.08	0.0%	app/util/analytics.py
20	83.33	0.0%	app/project_type/directory.py
20	100.0	0.0%	app/util/conf/master_config_loader.py
20	66.67	0.0%	app/web_framework/api_version_handler.py
21	100.0	0.0%	app/util/conf/slave_config_loader.py
21	100.0	0.0%	app/util/shell/local_shell_client.py
22	95.65	0.0%	app/master/build_store.py
22	57.89	0.0%	app/util/argument_parsing.py
22	39.29	0.0%	app/util/ordered_set_queue.py
24	100.0	0.0%	app/master/atomizer.py
25	100.0	0.0%	app/subcommands/master_subcommand.py
25	83.33	0.0%	app/util/shell/remote_shell_client.py
26	78.79	0.0%	app/master/subjob_calculator.py
26	100.0	0.0%	app/subcommands/slave_subcommand.py
27	79.41	0.0%	app/master/cluster_runner_config.py
29	87.88	0.0%	app/util/decorators.py
30	93.75	0.0%	app/master/slave_allocator.py
31	91.18	0.0%	app/subcommands/build_subcommand.py
32	100.0	0.0%	app/deployment/remote_master_service.py
32	100.0	0.0%	app/util/secret.py
32	86.49	0.0%	app/util/shell/shell_client.py
34	82.93	-0.41%	app/common/metrics.py
35	81.4	0.0%	app/subcommands/service_subcommand.py
36	76.6	0.0%	app/master/build_request_handler.py
36	82.61	0.0%	app/util/autoversioning.py
40	41.24	0.0%	app/client/cluster_api_client.py
41	89.13	0.0%	app/web_framework/route_node.py
44	50.57	0.0%	app/web_framework/cluster_slave_application.py
46	69.7	0.0%	app/client/service_runner.py
47	87.04	0.0%	app/master/build_fsm.py
49	94.23	0.0%	app/subcommands/stop_subcommand.py
49	76.56	0.0%	app/util/network.py
59	93.65	0.0%	app/master/subjob.py
59	89.39	0.0%	app/util/unhandled_exception_handler.py
60	98.36	0.0%	app/master/job_config.py
61	58.65	0.0%	app/web_framework/cluster_base_handler.py
62	100.0	0.0%	app/master/time_based_atom_grouper.py
63	98.44	0.0%	app/slave/subjob_executor.py
66	52.8	0.0%	app/subcommands/deploy_subcommand.py
69	68.32	0.0%	app/client/build_runner.py
75	97.4	0.0%	app/master/build_scheduler.py
75	38.27	0.0%	app/web_framework/cluster_master_application.py
77	96.25	0.0%	app/project_type/git.py
87	76.99	0.0%	app/util/event_log.py
99	86.09	0.0%	app/util/conf/base_config_loader.py
107	81.68	0.0%	app/master/slave.py
114	77.7	0.52%	app/master/cluster_master.py
141	94.0	0.0%	app/slave/cluster_slave.py
149	79.68	0.0%	app/project_type/project_type.py
276	94.85	0.0%	app/master/build.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	1961.1 (TARGETS="lint test-unit-with-coverage")	10 Mar 2018 09:28AM UTC	95	76.36	Travis Job 1961.1
2	1961.2 (TARGETS="test-integration-with-coverage")	10 Mar 2018 09:26AM UTC	95	5.77	Travis Job 1961.2
3	1961.3 (TARGETS="test-functional test-unit-via-clusterrunner")	10 Mar 2018 09:31AM UTC	0		Travis Job 1961.3

Source Files on build 1961

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

box / ClusterRunner / 1961
5%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 1961

box / ClusterRunner / 1961 5%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 1961

box / ClusterRunner / 1961
5%

README BADGES
x