sass / node-sass / 3158

69%

push

travis-ci

Install script should not write partially downloaded binaries

Currently the binary download is streamed to disk once a 200 response
has been recieved. When an error occurs during the download a partially
downloaded binary is left on disk. Subsequent installs see the binary
and bail out of re-downloading it. Worse yet those subsequent installs
move the binary into the global cache so even removing node_modules
will not remove the broken binary.

With this patch the binary is only flushed to disk once it has been
fully downloaded.

Fixes #1882
Fixes #1888

134 of 197 branches covered (68.02%)

252 of 334 relevant lines covered (75.45%)

1007.95 hits per line