665
65%

Ran 07 Mar 2018 08:14AM UTC

Jobs 1

Files 29

Run time 1s

Badge

Embed ▾

pending completion

Build # 665

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix client side cancellation && signal (#401)

* bugfix: child / external workflow signal / cancellation combination were not handled correctly if child does continue as new.

* bugfix: child workflow cancellation does not validate input run ID, which can corrupt internal state machine.

* bugfix: workflow cancellation state machine should not use target workflow ID as identifier, right now use seuqence ID as unique identifier.

* bugfix: *childWorkflowFutureImpl should be use as function receiver, instead of childWorkflowFutureImpl

* add testsuite case

* back to use child workflow state machine for child workflow cancellation

Run Details

238 of 238 new or added lines in 6 files covered. (100.0%)

5286 of 8118 relevant lines covered (65.11%)

118.34 hits per line

New Missed Lines in Diff

Lines	Coverage	File
8	100.0	internal/workflow.go
10	100.0	internal/internal_decision_state_machine.go
14	100.0	internal/internal_workflow_testsuite.go
63	100.0	internal/internal_event_handlers.go

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	internal/internal_event_handlers.go
3	100.0	internal/internal_workflow_testsuite.go
7	100.0	internal/internal_task_pollers.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	665.1	07 Mar 2018 08:14AM UTC	0	65.11	Travis Job 665.1

Source Files on build 665

Detailed source file information is not available for this build.

uber-go / cadence-client / 665
65%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 665

uber-go / cadence-client / 665 65%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 665

uber-go / cadence-client / 665
65%

README BADGES
x