mysociety / pombola / 3848
60%

DEFAULT BRANCH: master
Ran
Jobs 1
Files 405
Run time 19s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
3848

push

travis-ci

mhl 
Don't error on a ZERO_RESULTS exception from Google's geocoder

We're getting quite a lot of email errors on PA for people
searching for places which cause pygeocoder to return a
ZERO_RESULTS exception. Here's an example error:

    Internal Server Error: /search/location/
    Traceback (most recent call last):
      File "[...]/pombola-virtualenv/lib/python2.7/site-packages/django/core/handlers/base.py", line 132, in get_response
        response = wrapped_callback(request, *callback_args, **callback_kwargs)
      File "[...]/pombola-virtualenv/lib/python2.7/site-packages/django/views/generic/base.py", line 71, in view
        return self.dispatch(request, *args, **kwargs)
      File "[...]/pombola-virtualenv/lib/python2.7/site-packages/django/views/generic/base.py", line 89, in dispatch
        return handler(request, *args, **kwargs)
      File "[...]/pombola/pombola/south_africa/views/geolocalization.py", line 37, in get
        context = self.get_context_data(**kwargs)
      File "[...]/pombola/pombola/search/views.py", line 354, in get_context_data
        context['geocoder_results'] = geocoder(country=country_alpha2, q=query)
      File "[...]/pombola/pombola/search/geocoder.py", line 10, in geocoder
        response = geocoder.geocode(q, components=components)
      File "[...]/pombola-virtualenv/lib/python2.7/site-packages/pygeocoder.py", line 127, in geocode
        return GeocoderResult(self.get_data(params=params))
      File "[...]/pombola-virtualenv/lib/python2.7/site-packages/pygeocoder.py", line 212, in get_data
        raise GeocoderError(response_json['status'], response.url)
    GeocoderError: Error ZERO_RESULTS
    Query: https://maps.google.com/maps/api/geocode/json?key=[...]&language=&region=&bounds=&components=country%3Aza&address=Nonaliti&sensor=false

    Request repr():
    <WSGIRequest
    path:/search/location/,
    GET:<QueryDict: {u'q': [u'Nonaliti']}>,
   POST:<QueryDict: {}>,

This commit handles exceptions with that st... (continued)

10625 of 19453 relevant lines covered (54.62%)

0.55 hits per line

Jobs
ID Job ID Ran Files Coverage
1 3848.1 (ES_VERSION=0.90.13 ES_DOWNLOAD_URL=https://download.elastic.co/elasticsearch/elasticsearch/elasticsearch-${ES_VERSION}.tar.gz) 0
54.62
 Travis Job 3848.1
Source Files on build 3848
Detailed source file information is not available for this build.