12
72%

Ran 05 Mar 2018 02:32PM UTC

Jobs 1

Files 393

Run time 29s

Badge

Embed ▾

pending completion

Build # 12

Build Type

push

jenkins

Committed by

sijie

Commit Message

Fix AbstractLedgerManagerFactory on handling both shaded class and original class co-exists case

Descriptions of the changes in this PR:

*Problem*

#1217 addresses the issue when using a shaded class accessing a bookkeeper cluster.  However the assumption was made when the classpath only has shaded classes. However, it didn't address the case when shaded class and original class can co-exist. because IOException is thrown instead of ClassNotFoundException at following code:

```
                Class<?> theCls = Class.forName(layout.getManagerFactoryClass());
                if (!LedgerManagerFactory.class.isAssignableFrom(theCls)) {
                    throw new IOException("Wrong ledger manager factory " + layout.getManagerFactoryClass());
                }
```

*Solution*

This change fixes the issue.

Author: Sijie Guo <sijie@apache.org>

Reviewers: Jia Zhai <None>, Matteo Merli <mmerli@apache.org>

This closes #1227 from sijie/debug_issue

Run Details

22748 of 31389 relevant lines covered (72.47%)

0.72 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	12.1	05 Mar 2018 02:32PM UTC	0	72.47

Source Files on build 12

Detailed source file information is not available for this build.

apache / bookkeeper / 12
72%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12

apache / bookkeeper / 12 72%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 12

apache / bookkeeper / 12
72%

README BADGES
x