2076
91%
main: 93%

Ran 01 Mar 2018 04:10PM UTC

Jobs 10

Files 66

Run time 12min

Badge

Embed ▾

pending completion

Build # 2076

Build Type

Pull #340

travis-ci

Committed by

web-flow

Commit Message

Fix outdated call to #next_pid in SuriService

If `Config.suri.mint_ids` is false, the SuriService raises a NoMethodError calling `#next_pid` on a Rubydora::Repository instance. Rubydora::Repository instances do not define this method; the method is defined on Rubydora::RestApiClient which can be accessed via `#api` on the repository. Additionally, the xpath that is used in the same `else` clause no longer parses pids out of the `pidList`. I have added code that tries a second XPath if the first fails.

I made these changes so the latest hydra_etd work can use dor-services without patching around the SuriService.

Pull Request Pull Request #340: Fix outdated call to #next_pid in SuriService

Run Details

3 of 3 new or added lines in 1 file covered. (100.0%)

3229 of 3563 relevant lines covered (90.63%)

188.63 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	94.12	-5.88%	lib/dor/services/suri_service.rb

Uncovered Existing Lines

Lines	Coverage	∆	File
3	94.87	0.0%	lib/dor/models/concerns/identifiable.rb

Jobs

ID	Job ID	Ran	Files	Coverage
1	2076.1 (2.3.5, RAILS_VERSION="~> 4.2")	01 Mar 2018 04:10PM UTC	66	90.54	Travis Job 2076.1
2	2076.2 (2.3.5, RAILS_VERSION="~> 5.0")	01 Mar 2018 04:15PM UTC	66	90.54	Travis Job 2076.2
3	2076.3 (2.3.5, RAILS_VERSION="~> 5.1")	01 Mar 2018 04:17PM UTC	66	90.54	Travis Job 2076.3
4	2076.4 (2.4.2, RAILS_VERSION="~> 4.2")	01 Mar 2018 04:18PM UTC	66	90.54	Travis Job 2076.4
5	2076.5 (2.4.2, RAILS_VERSION="~> 5.0")	01 Mar 2018 04:23PM UTC	66	90.54	Travis Job 2076.5
6	2076.6 (2.4.2, RAILS_VERSION="~> 5.1")	01 Mar 2018 04:20PM UTC	66	90.54	Travis Job 2076.6
7	2076.7 (2.2.8, AF_VERSION="~> 6.0" RAILS_VERSION="~> 4.2.5.2")	01 Mar 2018 04:20PM UTC	66	90.13	Travis Job 2076.7
8	2076.8 (2.3.5, AF_VERSION="~> 6.0" RAILS_VERSION="~> 4.2")	01 Mar 2018 04:22PM UTC	66	90.15	Travis Job 2076.8
9	2076.9 (2.3.5, AF_VERSION="~> 7.0" RAILS_VERSION="~> 4.2")	01 Mar 2018 04:22PM UTC	66	90.51	Travis Job 2076.9
10	2076.10 (2.3.5, AF_VERSION="~> 8.0" RAILS_VERSION="~> 4.2")	01 Mar 2018 04:23PM UTC	66	90.54	Travis Job 2076.10

Source Files on build 2076

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

sul-dlss / dor-services / 2076
91%
main: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 2076

sul-dlss / dor-services / 2076 91% main: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 2076

sul-dlss / dor-services / 2076
91%
main: 93%

README BADGES
x