cyverse / atmosphere / 1001

37%

master: 37%

Pull #585

travis-ci

Fix invalid argument to check_allocation

When an instance is started, a call is made to check_allocation with an
allocation source snapshot. However, check_allocation expects an
allocation_source.

Here is a stack trace, which would lead to the assertion error

  /opt/dev/atmosphere/api/v2/views/instance.py(99)actions()
     98             return self.list_instance_actions(request, pk=pk)
---> 99         return self.post_instance_action(request, pk=pk)
    100

  /opt/dev/atmosphere/api/v2/views/instance.py(119)post_instance_action()
    118         try:
--> 119             result_obj = run_instance_action(user, identity, instance_id, action, action_params)
    120             api_response = {

  /opt/dev/atmosphere/service/instance.py(2054)run_instance_action()
   2053         instance_allocation_source = InstanceAllocationSourceSnapshot.objects.get(instance__provider_alias=instance_id)
-> 2054         check_allocation(user.username, instance_allocation_source)
   2055     if 'resize' == action_type:

  /opt/dev/atmosphere/service/instance.py(1327)check_allocation()
   1326     enforcement_override_choice = AllocationSourcePluginManager.get_enforcement_override(user,
-> 1327                                                                                          allocation_source)
   1328     logger.debug('check_allocation - enforcement_override_choice: %s', enforcement_override_choice)

  /opt/dev/atmosphere/core/plugins.py(200)get_enforcement_override()
    199                                                                            allocation_source=allocation_source,
--> 200                                                                            provider=provider)
    201             if _enforcement_override_choice != EnforcementOverrideChoice.NO_OVERRIDE:

  /opt/dev/atmosphere/cyverse_allocation/plugins/allocation_source.py(39)get_enforcement_override()
     38         """
---> 39         return _get_enforcement_override(allocation_source... (continued)

1054 of 7084 branches covered (14.88%)

Branch coverage included in aggregate %.

3 of 3 new or added lines in 1 file covered. (100.0%)

11898 of 28240 relevant lines covered (42.13%)

0.82 hits per line