2388
84%

Ran 26 Feb 2018 12:19PM UTC

Jobs 2

Files 128

Run time 13s

Badge

Embed ▾

pending completion

Build # 2388

Build Type

push

travis-ci

Committed by

felliott

Commit Message

Merge branch 'feature/range-header-handling' into develop

 * Teach WB to correctly interpret incoming Range headers. It had been
   returning one more byte than requested due to a misunderstanding of
   how a utility library worked.  The issue manifested as the
   inability of Safari to play videos from WB.  @abought and
   @Johnetordoff discovered that Safari makes a two-byte range request
   before playing the file.  WB was returning a three-byte response,
   causing Safari to refuse to play the videos.

 * Teach WB to release partial responses.  A side effect of fixing the
   range handling was that partial responses were never reaching their
   EOF.  Streams only signal EOF when a read is issued after the feed
   has been exhausted.  Since partial response return exactly the
   number of bytes within them, this never occurs.

 * Add Range header support to Figshare, GitLab, and the filesystem
   providers.  Bitbucket, GitLab, and Dataverse do not support this
   header and will continue to return full responses if received.

 * Add range header support tests for all providers that support them.

 * Add logger modules to all providers.

 * These changes are only being made for v1.  v0 is deprecated and is
   expected to be removed soon.

 [SVCS-319]
 Closes: #318
 Closes: #234

Run Details

6094 of 6763 relevant lines covered (90.11%)

1.8 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	2388.1 (WATERBUTLER_CONFIG=./travis-config.json)	26 Feb 2018 12:20PM UTC	0	90.11	Travis Job 2388.1
2	2388.2 (WATERBUTLER_CONFIG=./travis-config.json)	26 Feb 2018 12:19PM UTC	0	90.11	Travis Job 2388.2

Source Files on build 2388

Detailed source file information is not available for this build.

CenterForOpenScience / waterbutler / 2388
84%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2388

CenterForOpenScience / waterbutler / 2388 84%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2388

CenterForOpenScience / waterbutler / 2388
84%

README BADGES
x