frictionlessdata / goodtables-py / 649
81%

DEFAULT BRANCH: master
Ran
Jobs 5
Files 41
Run time 34s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
649

push

travis-ci

web-flow 
Simplify error, cells, and checks signature, and add report validation JSON Schema

* Extract error dict into Error class and don't modify received "errors" argument

By using a class, we keep the knowledge on what fields the error dict
contains into a single place, making it easier both to document the format, and
to modify it if needed.

Regarding the "errors" argument, I modified the code to return the errors found
instead of appending to an output variable. This makes the functions closer to
being idempotent (some still modify the "cells" array), and are more Pythonic
overall.

* Add JSON Schema for validation report

It allow us not only to validate the report, but can also be used as a basis to
document it.

* Move cell creation to goodtables.cells and simplify @check arguments

This reduces the repetition on cell creation, and creates a single place to add
functions that handle cells.

Initially, I created a `Cell` class to handle this. However, as noted by @roll,
this creates performance issues as we're creating an object for each cell in a
potentially large table. Using built-in structures is faster.

I also added the `row-number` to the cell itself, and renamed `number` to
`column-number`. To avoid breaking other people's codes, `number` still exists,
but our code only uses `column-number`. We can remove it in the future.

Regarding @check, I modified it to not need to pass the `type` and `context` on
the default checks, as they're already defined in the spec.json. This should
have been a separate commit.

1085 of 1178 relevant lines covered (92.11%)

3.68 hits per line

Jobs
ID Job ID Ran Files Coverage
1 649.1 0
92.11
 Travis Job 649.1
2 649.2 0
92.11
 Travis Job 649.2
3 649.3 0
92.11
 Travis Job 649.3
4 649.4 0
92.02
 Travis Job 649.4
5 649.5 (TOXENV=lint) 0
Travis Job 649.5
Source Files on build 649
Detailed source file information is not available for this build.