brigand / babel-plugin-flow-react-proptypes / 380

93%

push

travis-ci

Allow `arrayOf`/`objectOf` elements to be required (#184)

* Add tests for `arrayOf`/`objectOf` required types

These tests currently fail.

wchargin-branch: arrayof-objectof-elements-required-tests

* Allow `arrayOf`/`objectOf` elements to be required

Summary:
Fixes #183; see rationale there.

Test Plan:
The code change to `convertToPropTypes` is sufficient to fix the tests
added and modified in the previous commit:

    yarn test objectof generic-array

Obviously, this is a wide-reaching change, so several other snapshots
were invalidated. I generated them, and manually inspected the results
to ensure that the changes are correct. They are, as far as I can tell;
the arrays of external types are harder to read, but by comparison with
surrounding code they seem okay to me.

wchargin-branch: arrayof-objectof-elements-required

501 of 559 branches covered (89.62%)

Branch coverage included in aggregate %.

4 of 4 new or added lines in 1 file covered. (100.0%)

597 of 633 relevant lines covered (94.31%)

131.17 hits per line