• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

node-red / node-red-web-nodes / 453
71%

Build:
DEFAULT BRANCH: master
Ran 15 Feb 2018 07:19PM UTC
Jobs 3
Files 22
Run time 71min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
453

push

travis-ci

dceejay
Improve pinboard error handling (#213)

* Improve code style

Remove trailing whitespaces
Add semicolons

* Improve pinboard error handling

Use HTTPS.

Check the HTTP status code to avoid trying to parse empty JSON messages.
Catch JSON parsing errors.

* Speed up pinboard tests

Instead of using timeouts, use sinon.js to stub the error functions.
This also improves code quality as the test code no longer needs to know
the logging internals.

* Test pinboard network requests

use nock to intercept pinboard network requests.
Change http.get to http.request to play nice with our 4-year old version
of nock.
If the server (or network mock) sends no HTTP status message, improvise.
Show user-friendly, translatable status messages, log raw errors.

1288 of 2045 branches covered (62.98%)

16 of 16 new or added lines in 1 file covered. (100.0%)

2554 of 3534 relevant lines covered (72.27%)

11.09 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
100.0
pinboard/pinboard.js
Jobs
ID Job ID Ran Files Coverage
1 453.1 (CXX="g++-4.8") 15 Feb 2018 07:28PM UTC 0
72.27
Travis Job 453.1
2 453.2 (CXX="g++-4.8") 15 Feb 2018 07:31PM UTC 0
72.27
Travis Job 453.2
3 453.3 (CXX="g++-4.8") 15 Feb 2018 08:30PM UTC 0
72.21
Travis Job 453.3
Source Files on build 453
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #453
  • 49b051d0 on github
  • Prev Build on master (#449)
  • Next Build on master (#454)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc