node-red / node-red-web-nodes / 453

71%

push

travis-ci

Improve pinboard error handling (#213)

* Improve code style

Remove trailing whitespaces
Add semicolons

* Improve pinboard error handling

Use HTTPS.

Check the HTTP status code to avoid trying to parse empty JSON messages.
Catch JSON parsing errors.

* Speed up pinboard tests

Instead of using timeouts, use sinon.js to stub the error functions.
This also improves code quality as the test code no longer needs to know
the logging internals.

* Test pinboard network requests

use nock to intercept pinboard network requests.
Change http.get to http.request to play nice with our 4-year old version
of nock.
If the server (or network mock) sends no HTTP status message, improvise.
Show user-friendly, translatable status messages, log raw errors.

1288 of 2045 branches covered (62.98%)

16 of 16 new or added lines in 1 file covered. (100.0%)

2554 of 3534 relevant lines covered (72.27%)

11.09 hits per line