1973
51%

Ran 15 Feb 2018 02:00AM UTC

Jobs 2

Files 80

Run time 361min

Badge

Embed ▾

pending completion

Build # 1973

Build Type

push

travis-ci

Committed by

peterbourgon

Commit Message

Service Discovery support for etcd v3 (#663)

* Service Discovery support for etcd v3

This adds a go-kit/kit/sd implementation for etcd/clientv3. All tests except the
client_test were ported over.

I have removed the client tests because they are
more problematic with regards to etcd v3. The etcd maintainers
switched to protobufs in v3 and placed those generated messages under
internal/, which would cause issues trying to reference it
(see https://golang.org/s/go14internal).
This makes stubbing clientv3.KV more difficult without burying the
implementation behind interfaces to remove the direct dependence
on those internal packages.

Features in use with v3:
- Support for etcd/clientv3.Watcher
- Support for etcd/clientv3.Lease (TTL)
- Username/password support

* - dead code cleanup
- moved global structs inside of test functions since they are not used
  anywhere else
- moved unused Err variable
- removed error return type from close()
- added doc comment

Run Details

3969 of 5155 relevant lines covered (76.99%)

56029.88 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	1973.1 (COVERALLS_TOKEN=MYSkSqcsWXd6DmP6TnSeiDhtvuL4u6ndp)	15 Feb 2018 02:00AM UTC	80	76.8	Travis Job 1973.1
2	1973.2 (COVERALLS_TOKEN=MYSkSqcsWXd6DmP6TnSeiDhtvuL4u6ndp)	15 Feb 2018 02:01AM UTC	80	76.95	Travis Job 1973.2

Source Files on build 1973

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

go-kit / kit / 1973
51%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1973

go-kit / kit / 1973 51%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1973

go-kit / kit / 1973
51%

README BADGES
x