mathiasbynens / esrever / 46

81%

push

travis-ci

Build up result in array instead of strings

Incrementally concatenating strings means a lot of intermediate strings get allocated only to be thrown away. The result is O(n**2) in both space and time. See this post about “Shlemiel the painter’s algorithm” for a good description about the quadratic behavior involved: https://www.joelonsoftware.com/2001/12/11/back-to-basics/

Storing each fragment in an array and joining them all together in the end at least avoids allocating ever-longer intermediate strings. I have not run any benchmarks on very long strings,
though. That might still be interesting to do.

Closes #12.

16 of 25 branches covered (64.0%)

21 of 26 relevant lines covered (80.77%)

97.15 hits per line