• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

caicloud / nirvana / 494
46%

Build:
DEFAULT BRANCH: master
Ran 11 Feb 2018 09:44AM UTC
Jobs 2
Files 69
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
494

push

travis-ci

caicloud-bot
fix(definition): remove builder pattern (#165)

Automatic merge from submit-queue.

fix(definition): remove builder pattern

**What this PR does / why we need it**:

- fix(definition): remove builder pattern

**Which issue(s) this PR fixes** *(optional, close the issue(s) when PR gets merged)*:

Fixes #125 

**Special notes for your reviewer**:

/assign @Jimexist 
/assign @ddysher 
/kind cleanup

**Release note**:


```release-note
Remove builder pattern for definition
```

<!--  Thanks for sending a pull request! Here are some tips:

1. https://github.com/caicloud/engineering/blob/master/docs/review_conventions.md  <-- what is the review process looks like
2. https://github.com/caicloud/engineering/blob/master/docs/commit_conventions.md  <-- how to structure your git commit
3. https://github.com/caicloud/engineering/blob/master/docs/caicloud_bot.md        <-- how to work with caicloud bot

Other tips from Kubernetes cmomunity:

1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide
2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews
3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed
4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests
-->

15 of 15 new or added lines in 3 files covered. (100.0%)

3164 of 5611 relevant lines covered (56.39%)

44.6 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
5
100.0
examples/api-basic/api/v1/install.go
5
100.0
examples/api-basic/api/v2/install.go
5
100.0
examples/stream/api/v1/install.go

Uncovered Existing Lines

Lines Coverage ∆ File
1
100.0
examples/api-basic/api/v1/install.go
1
100.0
examples/api-basic/api/v2/install.go
1
100.0
examples/stream/api/v1/install.go
Jobs
ID Job ID Ran Files Coverage
1 494.1 11 Feb 2018 09:44AM UTC 0
56.39
Travis Job 494.1
2 494.2 11 Feb 2018 09:45AM UTC 0
56.39
Travis Job 494.2
Source Files on build 494
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #494
  • 81484595 on github
  • Prev Build on master (#491)
  • Next Build on master (#496)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc