228
97%

Ran 08 Feb 2018 07:01PM UTC

Jobs 6

Files 4

Run time 873min

Badge

Embed ▾

pending completion

Build # 228

Build Type

push

travis-ci

Committed by

lcarva

Commit Message

Combine environment variable substitution with quote removal

This fixes the tests added in the previous commit.

The EnvSubst class is renamed to WordSplitter, and provides
two methods:
* dequote() returns the string with quotes/escaped consumed
* split() breaks the string into words at whitespace

This new class can be told whether or not to apply
environment variable substitutions.

The way we process ENV/LABEL instructions is now to first
break the instruction value into words, without quoting or
applying environment variable substitutions. We can then
inspect the first word to find out which key/value form is
in use ("key=value" vs "key the value").

Based on this we now apply environment variable substitution
to each key and value separately, consuming quotes and
escape characters.

A similar process is used when modifying an ENV/LABEL
instruction, with the exception that key=value forms are
left alone with quotes and escapes intact unless modified.
This is the reason for changing some existing test cases.

Signed-off-by: Tim Waugh <twaugh@redhat.com>

Run Details

428 of 447 relevant lines covered (95.75%)

5.74 hits per line

Jobs

ID	Job ID	Ran	Coverage
1	228.1 (OS=centos OS_VERSION=6 PYTHON_VERSION=2)	08 Feb 2018 07:01PM UTC	95.75	Travis Job 228.1
2	228.2 (OS=centos OS_VERSION=7 PYTHON_VERSION=2)	08 Feb 2018 07:02PM UTC	95.75	Travis Job 228.2
3	228.3 (OS=fedora OS_VERSION=26 PYTHON_VERSION=2)	08 Feb 2018 07:01PM UTC	95.75	Travis Job 228.3
4	228.4 (OS=fedora OS_VERSION=26 PYTHON_VERSION=3)	09 Feb 2018 09:34AM UTC	95.3	Travis Job 228.4
5	228.5 (OS=fedora OS_VERSION=27 PYTHON_VERSION=2)	08 Feb 2018 07:01PM UTC	95.75	Travis Job 228.5
6	228.6 (OS=fedora OS_VERSION=27 PYTHON_VERSION=3)	08 Feb 2018 07:03PM UTC	95.3	Travis Job 228.6

Source Files on build 228

Detailed source file information is not available for this build.

DBuildService / dockerfile-parse / 228
97%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 228

DBuildService / dockerfile-parse / 228 97%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 228

DBuildService / dockerfile-parse / 228
97%

README BADGES
x