se-edu / addressbook-level4 / 4120

94%

Pull #793

travis-ci

BrowserPanel: load placeholder page instead of Google search page

BrowserPanel loads the Google search page whenever a person card is
selected, and there’s tests written for this feature.

When many forks of this project are running automated tests, too many
search requests are sent to Google, causing us to exceed the search
service’s rate limits. This is an abuse of Google’s search service.
Also, this causes our tests to fail as the loaded web page will be
redirected to a captcha page.

Let’s update BrowserPanel to load DummySearchPage.html which is hosted
on GitHub Pages. GitHub Pages serve static web pages which requires
much less processing power, thus it is more unlikely for us to exceed
the search service’s rate limits.

Also, let’s remove Google String constants as they are no longer used.

1 of 1 new or added line in 1 file covered. (100.0%)

1435 of 1560 relevant lines covered (91.99%)

0.92 hits per line