2246
100%

Ran 07 Feb 2018 10:21AM UTC

Jobs 1

Files 66

Run time 7s

Badge

Embed ▾

pending completion

Build # 2246

Build Type

api

travis-ci

Committed by

ben-manes

Commit Message

Fix weighted SLRU demotion when decrementing the region's size

The protected space's size was decremented by the promoted entry's
weight, rather than the demoted entry's. When entries have the same
weight, e.g. maximumSize, this is the same. The cache will still evict
when the overall capacity has been reached, so this only caused the
wrong accounting.

The test EvictionTest#evict_weighted was known to fail on CI, though
seemed to be flaky. The assumption was this was due to the randomness
in the seeds, though recently making those stable seemed to fix it
until it reappeared yesterday. The mistake was discovered when working
on the adaptive policy, so a fortunate coincidence.

Since this failure is difficult to trigger, hopefully not seeing the
test case fail will mean we've fixed it.

Coverage Stats

5731 of 6095 relevant lines covered (94.03%)

0.94 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	2246.2 (GROUP=tests)	07 Feb 2018 10:21AM UTC	0	94.03	Travis Job 2246.2

Source Files on build 2246

Detailed source file information is not available for this build.

ben-manes / caffeine / 2246
100%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2246

ben-manes / caffeine / 2246 100%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 2246

ben-manes / caffeine / 2246
100%

README BADGES
x