nose-devs / nose2 / 610

88%

Pull #380

travis-ci

Respect fail_under coverage config

Resolves #285

- Nose2 ResultSuccessEvent events can only indicate exit(0) or exit(1),
  so without a brand new exit status handling mechanism, we can't get
  exit(2) which `coverage` does for fail_under. *This is fine*.
  Unless we expect nose2 to bend over backwards to reproduce all of the
  behaviors of coverage, this just needs to be documented.
- Previously, coverage was computed during afterSummaryReport. However,
  it must be computed before wasSuccessful in order to produce the
  correct resulting status with fail_under. Therefore, coverage is now
  computed during beforeSummaryReport, its output is buffered in a
  StringIO, and the result (for text output) is printed during
  afterSummaryReport. This should have no externally visible behavioral
  change.
- Add support to coverage tests for checking exit status, so that we can
  assert exit(1) on the fail_under test. Add a relevant test using this
  capability.
- Add documentation to coverage plugin detailing exit(2) vs exit(1)
  behavior, and leaving room for more `coverage` vs `nose2`
  discrepancies.

988 of 1218 branches covered (81.12%)

18 of 18 new or added lines in 1 file covered. (100.0%)

3252 of 3703 relevant lines covered (87.82%)

6.94 hits per line