pillarjs / cookies / 251

100%

Pull #94

travis-ci

maxAge should not be translated to expires

The expires argument includes the timezone, but the UA clock might
be offset by a couple of hours (incorrect timezone), which would
end-up in the following situation:

 - UTC is 2018-01-15 10:00 + 00:00
   Client has localtime: 2018-01-15 10:00 - 08:00 (8h in the future)
 - Server set cookie with maxAge = 30min
 - Server send:
     Set-Cookie: foo=bar; expires=2018-01-15T10:30:00+00:00
 - UA immediately expires the cookie
 - UA send a new request without cookie.

Sadly incorrect UA clock is a common problem (at least for us),
maxAge is a correct option (as the time is calculated relative
to UA clock), but this is not an available option in this library.

Signed-off-by: Arthur Gautier <baloo@gandi.net>

101 of 108 branches covered (93.52%)

2 of 2 new or added lines in 1 file covered. (100.0%)

110 of 110 relevant lines covered (100.0%)

174.47 hits per line