905
0%

Ran 30 Jan 2018 01:00PM UTC

Jobs 6

Files 50

Run time 11min

Badge

Embed ▾

pending completion

Build # 905

Build Type

Pull #219

travis-ci

Committed by

web-flow

Commit Message

utils: drop None-valued fields from _init_kwargs

The motivation for this change is partly to enable passing
the spider parameters as kwargs to 'action functions' which
can the fail if the parameters don't match the specification
(i.e. the signature) of the action. To enable this method
of verification we need to drop None-valued parameters.

We still leave them in _all_kwargs.

Signed-off-by: Szymon Łopaciuk <szymon.lopaciuk@cern.ch>

Pull Request Pull Request #219: utils: strictly check kwargs in spiders (#218)

Run Details

47 of 47 new or added lines in 22 files covered. (100.0%)

3916 of 4221 relevant lines covered (92.77%)

2.51 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	90.78	0.4%	hepcrawl/utils.py
2	97.37	0.07%	hepcrawl/spiders/cds_spider.py

Uncovered Existing Lines

Lines	Coverage	∆	File
1	100.0	0.0%	hepcrawl/spiders/arxiv_spider.py
1	100.0	0.0%	hepcrawl/testlib/utils.py
2	89.47	0.0%	hepcrawl/spiders/common/last_run_store.py
8	100.0	0.0%	hepcrawl/downloaders.py
13	96.06	0.0%	hepcrawl/tohep.py
15	55.56	0.0%	hepcrawl/testlib/tasks.py
18	91.03	0.0%	hepcrawl/pipelines.py
22	90.78	0.4%	hepcrawl/utils.py
29	95.89	0.03%	hepcrawl/spiders/pos_spider.py
31	88.89	0.32%	hepcrawl/spiders/common/oaipmh_spider.py
32	95.89	0.06%	hepcrawl/spiders/wsp_spider.py
33	98.25	0.02%	hepcrawl/spiders/desy_spider.py
35	97.37	0.07%	hepcrawl/spiders/cds_spider.py
38	90.14	0.0%	hepcrawl/middlewares.py
45	86.54	0.0%	hepcrawl/testlib/celery_monitor.py

Jobs

ID	Job ID	Ran	Files	Coverage
1	905.1 (SUITE=unit)	30 Jan 2018 01:00PM UTC	50	85.07	Travis Job 905.1
2	905.2 (SUITE=functional_wsp)	30 Jan 2018 01:02PM UTC	50	34.49	Travis Job 905.2
3	905.3 (SUITE=functional_arxiv)	30 Jan 2018 01:04PM UTC	50	34.92	Travis Job 905.3
4	905.4 (SUITE=functional_desy)	30 Jan 2018 01:07PM UTC	50	32.2	Travis Job 905.4
5	905.5 (SUITE=functional_cds)	30 Jan 2018 01:11PM UTC	50	29.87	Travis Job 905.5
6	905.6 (SUITE=functional_pos)	30 Jan 2018 01:12PM UTC	50	34.45	Travis Job 905.6

Source Files on build 905

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

inspirehep / hepcrawl / 905
0%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 905

inspirehep / hepcrawl / 905 0%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 905

inspirehep / hepcrawl / 905
0%

README BADGES
x