xapi-project / sm / 527

47%

push

travis-ci

<a href="https://github.com/xapi-project/sm/commit/<a class=hub.com/xapi-project/sm/commit/2a5bc6db2fa6678367c82685b7dec99bc32d339a">2a5bc6db2<a href="https://github.com/xapi-project/sm/commit/2a5bc6db2fa6678367c82685b7dec99bc32d339a">&quot;&gt;CA-257740: Fix HA broken for NFS

Commit &lt;/a&gt;&lt;a class=&quot;double-link&quot; href=&quot;https://github.com/xapi-project/sm/commit/&amp;lt;a class=&amp;quot;double-link&amp;quot; href=&amp;quot;https://git&quot;&gt;&amp;lt;a class=</a>hub.com/xapi-project/sm/commit/&lt;a class=&quot;double-link&quot; href=&quot;https://git">&lt;a class=</a>hub.com/xapi-project/sm/commit/<a class=hub.com/xapi-project/sm/commit/<a class="double-link" href="https://git"><a class=hub.com/xapi-project/sm/commit/8a19f82dcf7d6e1737908f7e2380bdb216404991">8a19f82dc">8a19f82dc</a><a href="https://github.com/xapi-project/sm/commit/2a5bc6db2fa6678367c82685b7dec99bc32d339a"> had introduced
a regression causing attach_from_config to fail, meaning the host
would not boot properly with HA enabled since the attach static VDI
would fail and ha_start_daemon would fail as well because there would
not be any static VDI attached.

Before 8a19f82dcf7d6e1737908f7e2380bdb216404991 FileVDI.load was failing
during attach_from_config since the SR was not mounted but managed to set

   &#39;self.path = raw_path&#39;

before failing.

After 8a19f82dcf7d6e1737908f7e2380bdb216404991 FileVDI.load was still
failing during attach_from_config since the SR was not mounted but
it was leaving

    &#39;self.path = None&#39;

This commit is fixing the problem by checking if &#39;self.path is None&#39;
and calling self._find_path_with_retries() again to set the path after
the SR is mounted.

Signed-off-by: Stefano Panella &lt;stefano.panella@citrix.com&gt;
Signed-off-by: Mark Syms &lt;mark.syms@citrix.com&gt;
Signed-off-by: Edvin Torok &lt;edvin.torok@citrix.com&gt;
Reviewed-by: Edwin Török &lt;edvin.torok@citrix.com&gt;</a>

817 of 6335 branches covered (12.9%)

6970 of 20722 relevant lines covered (33.64%)

0.34 hits per line