1452
63%

Ran 29 Jan 2018 01:10PM UTC

Jobs 1

Files 56

Run time 3s

Badge

Embed ▾

pending completion

Build # 1452

Build Type

push

travis-ci

Committed by

raghavendra-talur

Commit Message

client:api: consolidate r.Body.Close() calls

Up to now, the calls to r.Body.Close() were scattered
across the functions in the golang api-client code.

r.Body.Close() was called in GetStringFromResponse,
GetErrorFromResponse, GetJsonFromResponse, and
GetJsonFromRequest.

But due to a bug, Get{String/Error}FromResponse
did not call the close in an error path (fixed
by a separate commit), and secondly, some code
paths in the API code don't call any of those functions.

So this changes tries to make sure that the
body is always closed by putting a call to
defer r.Body.Close() directly after the
instantiation via client.Do().

Signed-off-by: Michael Adam <obnox@redhat.com>

Run Details

4825 of 7003 relevant lines covered (68.9%)

1402.46 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
2	1452.2 (COVERAGE="true")	29 Jan 2018 01:10PM UTC	56	68.9	Travis Job 1452.2

Source Files on build 1452

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

heketi / heketi / 1452
63%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1452

heketi / heketi / 1452 63%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 1452

heketi / heketi / 1452
63%

README BADGES
x