• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

OpenConext / OpenConext-engineblock-metadata / 134
52%

Build:
DEFAULT BRANCH: master
Ran 29 Jan 2018 08:59AM UTC
Jobs 1
Files 44
Run time 2s
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
134

Pull #21

travis-ci

web-flow
Delete entities on metadata push

A metadata push by service registry contains metadata of all entities
that engineblock should know about. So all entities in the roles table
not present in the pushed metadata should be deleted on push.

This was already implemented but did not function as intended:

 - the deletion logic did not take into account entities that were
   updated instead of created

 - doctrines 'partial reference' cannot be used to delete entities
   since it does not load the database identifier when loaded by
   entity id

This commit changes the metadata deletion logic by keeping track of
what entity ids should be deleted, and deleting them with one query
when the metadata import has finished.
Pull Request #21: Delete entities on metadata push

18 of 18 new or added lines in 1 file covered. (100.0%)

930 of 1805 relevant lines covered (51.52%)

2.9 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
18
100.0
src/MetadataRepository/DoctrineMetadataRepository.php

Uncovered Existing Lines

Lines Coverage ∆ File
2
100.0
src/MetadataRepository/DoctrineMetadataRepository.php
Jobs
ID Job ID Ran Files Coverage
1 134.1 (EXECUTE_COVERAGE=true) 29 Jan 2018 08:59AM UTC 0
51.52
Travis Job 134.1
Source Files on build 134
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #134
  • Pull Request #21
  • PR Base - master (#122)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc