NewSpring / Apollos / 730

56%

Build Type

push

travis-ci

Committed by Conrad VanLandingham

Commit Message

237 give subnav (#243)

* Remove TmpGiveNavigator

* Start writing/styling give routes

* Split render logic between web and native

* Split logic

* Make GiveRoutes a bit more modular

* Patch isValid warning

isInitialValid does not accept a promise

* Allow grouped routes to render subroutes

* Do not render if a route does not exist

* Update react-native-tab to 0.0.74

* Build custom TabViewPagerPan

To keep the router in sync after the fact, still need to patch ios and android

* Only use TabViewPagerPanPatched on web

* Only pass handleOnChangeTab on web

* Make sure we can reach the correct index on the header consistently

* Remove silly console.log

* Remove TabViewPagerPatched

* backtrack on how route pushing is handled when navigating to the same route`

* use replace instead of push to prevent muddy history

* Patch propTypes

* Make TabView a context provider to easily share a `jumpTo` function

* Clean up and remove context

While context would allow deep usage of the prop the paradigm is to stay away from context when possible (plus this allows nested TabView's) just in case

Run Details

468 of 932 branches covered (50.21%)

Branch coverage included in aggregate %.

1040 of 1574 relevant lines covered (66.07%)

132.25 hits per line