• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

marshallward / f90nml / 402
99%

Build:
DEFAULT BRANCH: master
Ran 25 Jan 2018 04:21AM UTC
Jobs 8
Files 7
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

pending completion
402

push

travis-ci

marshallward
start_index and default_start_index bugfixes

This patch fixes some bugs related to setting the start_index and
default_start_index properties of Namelist.

First, we now parse args (via s_args) directly to check for start_index
when initialising the value.  We must do this prior to the __init__
call.  We must check args, since we next pass this to __init__ with the
_start_index keys removed.

We then call __init__, which expects and respects these values.  This
must be called after the start_index parsing.

Finally, we check and replace for any complex values inside __init__.
This must currently be done after init, since we manipulate the values
of `self` directly.  This should probably be changed someday to also
manipulate `args`, but not right now.

Also, a bug was fixed related to default_start_index, which was not
checking its value.  (It was checking the type of `self`, oops.)

Testing has also been slightly expanded.

8 of 8 new or added lines in 1 file covered. (100.0%)

1026 of 1034 relevant lines covered (99.23%)

7.87 hits per line

New Missed Lines in Diff

Lines Coverage ∆ File
1
100.0
f90nml/namelist.py
Jobs
ID Job ID Ran Files Coverage
1 402.1 25 Jan 2018 04:22AM UTC 0
98.45
Travis Job 402.1
2 402.2 25 Jan 2018 04:21AM UTC 0
98.07
Travis Job 402.2
4 402.4 25 Jan 2018 04:21AM UTC 0
98.55
Travis Job 402.4
5 402.5 25 Jan 2018 04:21AM UTC 0
98.55
Travis Job 402.5
6 402.6 25 Jan 2018 04:22AM UTC 0
98.55
Travis Job 402.6
7 402.7 25 Jan 2018 04:22AM UTC 0
98.55
Travis Job 402.7
8 402.8 25 Jan 2018 04:22AM UTC 0
98.16
Travis Job 402.8
9 402.9 25 Jan 2018 04:22AM UTC 0
98.45
Travis Job 402.9
Source Files on build 402
Detailed source file information is not available for this build.
  • Back to Repo
  • Travis Build #402
  • ba518ad4 on github
  • Prev Build on master (#401)
  • Next Build on master (#403)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc