aragon / aragonOS / 814

82%

Pull #182

travis-ci

Scripts suggestions (#199)

* ACL: remove unnecessary import

* Use _ prefix for arguments

* Comment clarifications or fixes

* ACL: use same interface for hasPermissions as Kernel

* ACL: clarify comment for when permisison creation is allowed

* Use _ROLE suffix for all role definitions

* Comment: remove script ID from EVMScript types since they can now be dynamic

* Always put visibility modifier ahead of state modifier

* AppProxyBase: remove unused event

* Rename IProxy to IAppProxy to reflect file name

* Use ^0.4.18 pragma for interfaces

* DeployDelegateScript: simplify caching

* EVMScriptRegistry: use constructor to add empty record

* IKernel: Add name to indexed event params for SetApp

* Small fixes

* CallsScript: fix dev comment

* EVMScriptRegistry: always inherit from interfaces first

* Fix compiler errors

* Add initialization to EVMScriptRegistry and make AppStorage more explicit

97 of 112 branches covered (86.61%)

Branch coverage included in aggregate %.

201 of 201 new or added lines in 18 files covered. (100.0%)

331 of 331 relevant lines covered (100.0%)

155.33 hits per line