locomotivemtl / charcoal-admin / 1093

9%

push

travis-ci

Refactor data assignment with request parameters

Enforce a stricter dataset for actions and templates.

Before, action and template controllers  would automatically assign all GET / POST data to itself. This behaviour often led to resolution conflicts and the practice alone is a major security risk.
Now, controllers must define a whitelist to automatically assign GET / POST parameters on itself.

Changes:
- Added `setDataFromRequest()` method to action and template controllers
- Added `validDataFromRequest()` method to action and template controllers
- Added `HttpAwareTrait` and implemented by widgets using HTTP Requests

142 of 142 new or added lines in 24 files covered. (100.0%)

386 of 13520 relevant lines covered (2.86%)

1.16 hits per line