254
88%

Ran 24 Nov 2014 01:14AM UTC

Jobs 2

Files 18

Run time 51s

Badge

Embed ▾

pending completion

Build # 254

Build Type

push

travis-ci

Committed by

oconnor663

Commit Message

make sure DEBUG_PARALLEL_COUNT is decremented on a plugin error

Summary:
This global is used in tests, to keep track of how many jobs run at
once. Jobs are supposed to increment it when they start and decrement it
when they finish. But if the plugin returned an error code, we were
throwing and failing to decrement that code.

This didn't repro for me locally, because the only tests that checked
the counter were happening early in my test run, but it caused Travis
failures because of a quirk in test run order.

This diff fixes the issue by putting the decrement in a finally clause,
and it extends the plugin tests so that all of them sanity check this
counter.

Reviewers: sean

Reviewed By: sean

Differential Revision: https://phabricator.buildinspace.com/D130

Run Details

588 of 635 relevant lines covered (92.6%)

1.85 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	254.1	24 Nov 2014 01:15AM UTC	0	92.6	Travis Job 254.1
2	254.2	24 Nov 2014 01:14AM UTC	0	92.44	Travis Job 254.2

Source Files on build 254

Detailed source file information is not available for this build.

buildinspace / peru / 254
88%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 254

buildinspace / peru / 254 88%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 254

buildinspace / peru / 254
88%

README BADGES
x