Ran
|
Jobs
1
|
Files
262
|
Run time
12s
|
Badge
Embed ▾
README BADGES
|
travis-ci
<a href="https://github.com/curl/curl/commit/<a class=hub.com/curl/curl/commit/aff19d4e812e7dd21c762d44c0246555b93cf353">aff19d4e8<a href="https://github.com/curl/curl/commit/aff19d4e812e7dd21c762d44c0246555b93cf353">">Fix SSH state machine for ssh-agent authentication In case an identity didn&#39;t match[0], the state machine would fail in state SSH_AUTH_AGENT instead of progressing to the next identity in ssh-agent. As a result, ssh-agent authentication only worked if the identity required happened to be the first added to ssh-agent. This was introduced as part of commit </a><a class="double-link" href="https://github.com/curl/curl/commit/<a class="double-link" href="https://github.com/curl/curl/commit/c4eb10e2f06fbd6cc904f1d78e4c7c5cc1afde63">c4eb10e2f</a>">c4eb10e2f</a><a href="https://github.com/curl/curl/commit/aff19d4e812e7dd21c762d44c0246555b93cf353">, which stated that the "else" statement was required to prevent getting stuck in state SSH_AUTH_AGENT. Given the state machine's logic and libssh2's interface I couldn't see how this could happen or reproduce it and I also couldn't find a more detailed description of the problem which would explain a test case to reproduce the problem this was supposed to fix. [0] libssh2_agent_userauth returning LIBSSH2_ERROR_AUTHENTICATION_FAILED
19591 of 26151 relevant lines covered (74.91%)
180827.17 hits per line
Lines | Coverage | ∆ | File |
---|---|---|---|
2 |
84.27 |
-0.24% | lib/imap.c |
4 |
55.2 |
-0.4% | lib/http2.c |
ID | Job ID | Ran | Files | Coverage | |
---|---|---|---|---|---|
16 | 7121.16 (T=coverage) | 262 |
74.91 |
Travis Job 7121.16 |
Coverage | ∆ | File | Lines | Relevant | Covered | Missed | Hits/Line |
---|