NCAR / manage_externals / 94

90%

push

travis-ci

Better error messages for failed commands

Merge remote-tracking branch 'wjs/print_command_error'

Two related changes here:

1. For any failed command run via execute_subprocess, print more
information about the problem to stdout

2. After doing an svn switch, check the status of the resulting
repository; if dirty, abort with a helpful message

The immediate purpose of both of these is to give more helpful error
messages if there are failures due to the presence of untracked files,
now that we attempt a checkout even if there are untracked files (via
overwritten by a tracked file in the new version:

git aborts the checkout with an error code; the new information
printed by (1) will help users in this case

svn attempts the checkout and returns a 0 error status, but may
leave you in a conflict state; we check this via (2)

Note that (2) should never happen currently (due to the up-front conservative
check of the repository status, which doesn't even allow untracked files), but
it will become possible after #57.

User interface changes?: No

Testing:
new unit tests added for some utility functions
unit tests: pass
system tests: pass
manual testing: For both git and svn, tested having an untracked file
in the working directory that gets overwritten after checking out a
new branch;

578 of 644 branches covered (89.75%)

Branch coverage included in aggregate %.

1908 of 2024 relevant lines covered (94.27%)

2.35 hits per line