713
32%

Ran 16 Jan 2018 01:00PM UTC

Jobs 2

Files 28

Run time 40s

Badge

Embed ▾

pending completion

Build # 713

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Fix a bunch of problems in TfJob CRD that crept in while tests were broken (#308)

* In syncTfJob when checking whether a work queue item corresponds to a TrainingJob already in the map we need to check the UID. Otherwise we will not properly handle the case where a training job is deleted and then a new job is recreated with the same name.

* We need to make sure that the Replicas field in TrainingJob is always properly set;

* We were only initializing replicas in setup which was problematic in the case where the TfJob controller gets restarted because on restarted setup won't be invoked because the job is past that phase and as a result the replicas won't be reinitialized.

* test_runner needs to ignore case when checking whether the job succeeded otherwise we conclude
that successful jobs failed

* The controller should only forget about job after the job has been cleaned up; not when it is marked as succeeded or failed.

* Add back code to support termination policies use the worker and not the master as the chief
    *This was added in #221 and accidentally removed in the refactor in #234.

Run Details

614 of 1953 relevant lines covered (31.44%)

2.54 hits per line

Uncovered Existing Lines

Lines	Coverage	File
2	100.0	pkg/util/util.go
2	100.0	pkg/trainer/tensorboard.go
8	100.0	pkg/apis/tensorflow/validation/validation.go
29	100.0	pkg/controller/controller.go
76	100.0	pkg/trainer/training.go
84	100.0	pkg/trainer/replicas.go

Jobs

ID	Job ID	Ran	Files	Coverage
1	713.1	16 Jan 2018 01:00PM UTC	0	31.44	Travis Job 713.1
2	713.2	16 Jan 2018 01:01PM UTC	0	31.44	Travis Job 713.2

Source Files on build 713

Detailed source file information is not available for this build.

tensorflow / k8s / 713
32%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 713

tensorflow / k8s / 713 32%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 713

tensorflow / k8s / 713
32%

README BADGES
x