stripe / stripe-go / 2308

66%

Pull #509

travis-ci

Handle all `json.Unmarshal` errors

We had a user over in #381 wondering why the errors from a
`json.Unmarshal` in `payout.go` wasn't being handled.

I believe the answer is that we've had a convention in here forever
whereby certain unmarshals from JSON blobs that are "low risk" are
assumed to succeed often enough that the error isn't worth handling. In
some of these `Unmarshal` implementations in particular, the `data` has
already been run through a previous `Unmarshal` so it's known that it
contains valid JSON and is unlikely to error on a second run.

Given that we've never had a complain about this before, it's probably
true that these `Unmarshals` are low risk and probably fine as is, but
nonetheless, it's still good practice to make sure that every error is
handled just in case. In this patch I've gone back through to any
`Unmarshal` invocations that were missing a check and added one.

34 of 34 new or added lines in 6 files covered. (100.0%)

3455 of 4533 relevant lines covered (76.22%)

99.44 hits per line