3179
57%

Ran 08 Jan 2018 10:52AM UTC

Jobs 1

Files 76

Run time 3s

Badge

Embed ▾

pending completion

Build # 3179

Build Type

push

travis-ci

Committed by

coolo

Commit Message

Polling the read socket in the capture loop (#902)

This change will make the capture loop more robust by polling the read socket to
detect half-open connections
When a connection is closed only on the other end if we try to read from it, an
error isn't yielded (not like how it happens with writes), creating an infinite
capture loop

There are three ways to solve this problem:
+ Send a message either to the application protocol (null message) or to the
  application protocol framing (an empty message)
  Disadvantages: Requires changes on both ends of the communication.

+ Polling the connections (Note: This is how HTTP servers work when dealing with
   persistent connections)
   Disadvantages: False positives

+ Change the keepalive packet settings
  Disadvantages: TCP/IP stacks are not required to support keepalives.

The first and last option, are a bit troublesome as we need to deal with restarts.
The first option also requires changes in both ends - Besides having to
enable/disabe the SIGPIPE capture on demand, when we have a SSH connection we
start hitting the error "bad packet length".

Run Details

3635 of 6644 relevant lines covered (54.71%)

411.79 hits per line

Uncovered Existing Lines

Lines	Coverage	∆	File
134	65.67	0.4%	/home/travis/build/os-autoinst/os-autoinst/backend/baseclass.pm

Jobs

ID	Job ID	Ran	Files	Coverage
1	3179.1	08 Jan 2018 10:52AM UTC	76	54.71	Travis Job 3179.1

Source Files on build 3179

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

os-autoinst / os-autoinst / 3179
57%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 3179

os-autoinst / os-autoinst / 3179 57%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Uncovered Existing Lines

Jobs

Source Files on build 3179

os-autoinst / os-autoinst / 3179
57%

README BADGES
x