jaegertracing / jaeger / 2592

100%

push

travis-ci

Introduce storage factory framework and composable CLI (#625)

* deprecate --span-storage.type CLI flag
* instead use env variable SPAN_STORAGE (and optionally DEPENDENCY_STORAGE)
* CLI options only include flags relevant to the selected storage type(s)
( introduce storage.Factory interface for creating different storage components like spanstore.Reader
* introduce meta-factory plugin/storage.Factory that instantiates concrete factories based on the above env vars
* concrete factories may implement plugin.Configurable interface that allows them to define custom CLI flags and to be initialized from Viper
* remove a lot of duplicated code for storage initialization in collector/query/standalone
* add new cobra command env that prints help about configuring via env vars

216 of 216 new or added lines in 9 files covered. (100.0%)

6961 of 6961 relevant lines covered (100.0%)

37.09 hits per line