TryGhost / Ghost-Admin / 3346

70%

push

travis-ci

🐛 Fixed navigation url inputs when configured URL has special characters (#941)

closes https://github.com/TryGhost/Ghost/issues/9373

- using an `<a>` element to parse a URL does not behave as expected when the URL has special characters because the `host` attribute will show the Puny URL version. Eg. `exämple.com` will become `xn--exmple-cua.com`
- `{{gh-navitem-url-input}}` was failing to manipulate the URL value because of the difference between the Puny URL encoded URL and the raw configured URL with unicode chars
- uses the `URI` module that's bundled with the imported version of `google-caja` to parse the URL via regexes rather than relying on native browser parsing

1698 of 2702 branches covered (62.84%)

17 of 17 new or added lines in 1 file covered. (100.0%)

4065 of 5641 relevant lines covered (72.06%)

40.8 hits per line