13276
82%
master: 93%

Ran 06 Jan 2018 04:22PM UTC

Jobs 1

Files 282

Run time 10s

Badge

Embed ▾

pending completion

Build # 13276

Build Type

push

travis-ci

Committed by

keradus

Commit Message

minor #3342 PhpUnitDedicateAssertFixer - Remove unexistent method is_boolean  (carusogabriel)

This PR was merged into the 2.2 branch.

Discussion
----------

PhpUnitDedicateAssertFixer - Remove unexistent method is_boolean

With this PR, I want to propose to removal of `is_boolean` from `PhpUnitDedicateAssertFixer`. As far as I know, `is_bool` does not have an alias in PHP. `is_int` and `is_float` have, but `is_bool` doesn't. As the proposal of `PhpUnitDedicateAssertFixer` is to fix e.g.:
```php
$this->assertTrue(is_string('foo'));
```
to
```php
$this->assertInternalType('string', 'foo');
```
the fixer will never find a
```php
$this->assertTrue(is_boolean(true));
```
I know that `PHPUnit`'s `assertInternalType` method [does support `assertInternalType('boolean', true)`](https://github.com/sebastianbergmann/phpunit/blob/master/src/Framework/Constraint/IsType.php#L119), but the fixer will never find an `is_boolean`.

Commits
-------

5120112f Remove unexistent method is_boolean from Fixer

Run Details

7410 of 9356 relevant lines covered (79.2%)

25.68 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
8	13276.8 (COLLECT_COVERAGE=1 SYMFONY_DEPRECATIONS_HELPER=weak)	06 Jan 2018 04:18PM UTC	0	79.2	Travis Job 13276.8

Source Files on build 13276

Detailed source file information is not available for this build.

FriendsOfPHP / PHP-CS-Fixer / 13276
82%
master: 93%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 13276

FriendsOfPHP / PHP-CS-Fixer / 13276 82% master: 93%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 13276

FriendsOfPHP / PHP-CS-Fixer / 13276
82%
master: 93%

README BADGES
x