brightinteractive / bright-js-framework / 297

83%

Pull #60

travis-ci

Fix issues loading data for dynamically inserted components

Previously, dynamically inserted components had their render method called on insertion into the DOM (with the result discarded). If they dependend on asynchronously loaded data to render then they would throw an exception. Additionaly, context was not provided at load time, meaning that load hooks failed if they tried to inject anything.

This fixes both of those issues and updates the test cases to use a more representative example of a data loader (which exposes both issues)

290 of 377 branches covered (76.92%)

Branch coverage included in aggregate %.

7 of 7 new or added lines in 3 files covered. (100.0%)

923 of 1064 relevant lines covered (86.75%)

41.4 hits per line