newsuk / times-components / 4947

89%

push

travis-ci

fix: ensure consistent scrolling behaviour on author profile (#488)

* fix: ensure consistent scrolling behaviour on author profile

The Next and Prev buttons should scroll to the top of the page when
clicked. Previously, they would scroll upwards, but either scroll too
far or not far enough. This was because the layout was recalculated
while the scroll was happening. This change delays the scroll until
after the layout so that it always scrolls to the top.

* Converted setTimeout to requestAnimationFrame

Also fixed a potential crash if the user somehow managed to navigate
away from from the view before the RAF callback fires.

78 of 80 branches covered (97.5%)

Branch coverage included in aggregate %.

204 of 207 relevant lines covered (98.55%)

30.55 hits per line