esl / MongooseIM / 3894

86%

push

travis-ci

mod_muc - fix for room registration race condition (#1608)

* Prepare for test

Add meck functions for mod muc

* Add regression tests, handle race condition

Tests are passing and started processes for identical rooms are terminated
The tests do not include check for the actual process, only the registered pid

* Remove comments

Some unused code was commented out, removed those comments

* Improve new test case names

Give the new test cases slightly more descriptive names

* Failing tests, investigating cause

Committing to checkout master

* Add sleep timer before mnesia read transaction

If Mnesia is slowed down by the tests the read operation will try to read
before a previous write transaction has completed.
The timer will now give the test some breathing room to complete the transaction

* Apply dialyzer fix

Added appropriate return value to function spec

* Apply review changes

Remove unnecessary sleeps in tests
Refactor record and macro definitions to header files
No longer ignore return value of mod_muc_room:route/5

* Apply requested changes

Revert header file changes
Use existing functions in tests instead of mnesia calls
Clarify function names in mod_muc previously related to routing
Add stop/1 function in mod_muc_room

26 of 26 new or added lines in 2 files covered. (100.0%)

6128 of 28164 relevant lines covered (21.76%)

464.38 hits per line