codedge-llc / pigeon / 352

85%

master: 84%

push

travis-ci

fix: stream_id exhaustion on connections (#97)

* fix: stream_id exhaustion on connections

* fix: removed now-useless reconnect? functionality

APNS/FCM config reconnect key still remains to not break API, though now
it doesn't do anything.

Also: cleaned up some compiler warnings.

* fix: connection asks for more demand on stream completion

Previous behavior was to ask for more demand as soon as events arrived,
though this leads to unreliable timeouts and such when Kadabra can't
process fast enough.

Potential issue: The requested streams don't timeout, so theoretically a
worker could hang if there was no response. Will also need to add an
error response for any :closed messages while there are outstanding
streams (though this should never happen for FCM session_timeouts)

Also fixed: FCM Poison parse failure hard crashes due to bad pattern
match. Now logs an error instead.

* fix: connections supervised again

Crashed connections will cause a memory leak with hpack/stream workers
in Kadabra. Will need to be addressed.

* chore: bump version number

* chore: update CHANGELOG

79 of 79 new or added lines in 6 files covered. (100.0%)

343 of 402 relevant lines covered (85.32%)

33.9 hits per line