897
91%

Ran 02 Jan 2018 08:44PM UTC

Jobs 1

Files 28

Run time 2s

Badge

Embed ▾

pending completion

Build # 897

Build Type

push

travis-ci

Committed by

web-flow

Commit Message

Remove with _with_options function variants (#308)

These were introduced to avoid potential conflicts between our options
parameter (named `opts`) and an `opts` function paramter named by the
Thrift IDL.

This resulted in doubling the number of generated methods (as well as
another level of function call indirection), in addition to making the
resulting user-callable API a little bit more complex.

Instead, go back to using just two generated functions (the "regular"
call and the "bang!" exception-raising variant) and rename our options
parameter to `rpc_opts`, which is very unlikely to conflict in practice.

Run Details

676 of 712 relevant lines covered (94.94%)

378.15 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
3	897.3 (COVERALLS=true)	02 Jan 2018 08:44PM UTC	0	94.94	Travis Job 897.3

Source Files on build 897

Detailed source file information is not available for this build.

pinterest / elixir-thrift / 897
91%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 897

pinterest / elixir-thrift / 897 91%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 897

pinterest / elixir-thrift / 897
91%

README BADGES
x