484
89%

Ran 02 Jan 2018 01:21PM UTC

Jobs 1

Files 14

Run time 1s

Badge

Embed ▾

pending completion

Build # 484

Build Type

push

travis-ci

Committed by

arekkas

Commit Message

errors: Removes stack trace for global errors (#96)

When including `errors.WithStack` in ladon's `Err*` exports, any time
this error is returned, its stacktrace will contain the _definition_.

For example, following snippet

    package main

    import (
        "fmt"
        "github.com/ory/ladon"
        "github.com/pkg/errors"
    )

    func main() {
        fmt.Printf("Error: %+v\n", errors.WithStack(ladon.ErrRequestDenied))
    }

will output

    Error: Request was denied by default
    github.com/chef/xx/vendor/github.com/ory/ladon.init
            /Users/stephan/go/src/github.com/chef/xx/vendor/github.com/ory/ladon/errors.go:25
    main.init
            <autogenerated>:1
    runtime.main
            /usr/local/Cellar/go/1.9.2/libexec/src/runtime/proc.go:183
    runtime.goexit
            /usr/local/Cellar/go/1.9.2/libexec/src/runtime/asm_amd64.s:2337
    main.main
            /Users/stephan/go/src/github.com/chef/xx/main.go:11
    runtime.main
            /usr/local/Cellar/go/1.9.2/libexec/src/runtime/proc.go:195

...of which only the second half is helpful.

Without the call in errors.go, the output will only contain the useful
bit:

    Error: Request was denied by default
    main.main
            /Users/stephan/go/src/github.com/chef/xx/main.go:11
    runtime.main
            /usr/local/Cellar/go/1.9.2/libexec/src/runtime/proc.go:195
    runtime.goexit
            /usr/local/Cellar/go/1.9.2/libexec/src/runtime/asm_amd64.s:2337

Signed-off-by: Stephan Renatus <srenatus@chef.io>

Run Details

456 of 519 relevant lines covered (87.86%)

80.28 hits per line

Jobs

ID	Job ID	Ran	Files	Coverage
1	484.1 (DOCKER_BIND_LOCALHOST=true)	02 Jan 2018 01:21PM UTC	0	87.86	Travis Job 484.1

Source Files on build 484

Detailed source file information is not available for this build.

ory / ladon / 484
89%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 484

ory / ladon / 484 89%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Jobs

Source Files on build 484

ory / ladon / 484
89%

README BADGES
x