graphql / graphql-js / 3006

99%

master: 98%

push

travis-ci

Only trigger "one instance of graphql" error in DEV environments.

This ensures the additional checking for multiple graphql instances only occurs in non-production builds. Not only does this improve the performance for production builds, it also solves a spurious error case for minified builds:

Since this additional check compares the `.name` of the constructors as a proxy for determining if two classes are representationally equal, minified builds may result in spurious false-positives if class names are minified to single-character names and those characters are likely to conflict.

This doesn't require `process` to exist (defaulting to the non-production mode), but bundlers like Webpack should consider using a stripping transform (see: https://webpack.js.org/guides/production/#specify-the-environment) in production builds if they also use a minifier.

4155 of 4671 branches covered (88.95%)

9 of 9 new or added lines in 1 file covered. (100.0%)

10374 of 10512 relevant lines covered (98.69%)

1570.78 hits per line