airbnb / airflow / 9017

0%

push

travis-ci

[AIRFLOW-1916] Don't upload logs to remote from `run --raw`

In a previous change we removed the
airflow.task.raw handler (which
printed to stdout directly) and replaced it with
one that wrote to the
log file itself. The problem comes that python
automatically calls
`logging.shutdown()` itself on process clean exit.
This ended up
uploading the log file twice: once from the end of
`airflow run --raw`,
and then again from the explicit shutdown() call
at the end of cli's
`run()`

Since logging is automatically shutdown this
change adds and explicit
flag to control if the GC and S3 handlers should
upload the file or not,
and we tell them not to when running with `--raw`

Closes #2880 from ashb/AIRFLOW-1916-dont-upload-
logs-twice

12 of 12 new or added lines in 4 files covered. (100.0%)

8932 of 12187 relevant lines covered (73.29%)

4.38 hits per line