reactjs / react-modal / 712

85%

Pull #581

travis-ci

[fixed] check if focusLaterElements is empty before popping

Without a check to see if the focusLaterElements array is empty, we
end up calling `pop()` on an empty array—resulting in an undefined
value—and inadvertently jump to the `catch` block when we attempt to
call `focus()` on `undefined`.

This ensures that if there are no existing elements to return focus to
once our modal is closed (this happens often in a testing env), we do
not throw a TypeError by accident.

230 of 355 branches covered (64.79%)

3 of 3 new or added lines in 1 file covered. (100.0%)

357 of 414 relevant lines covered (86.23%)

27.42 hits per line