3836
64%

Ran 11 Dec 2017 05:53PM UTC

Jobs 1

Files 95

Run time 4s

Badge

Embed ▾

pending completion

Build # 3836

Build Type

push

travis-ci

Committed by

ahaessly

Commit Message

Free Tier feature branch to dev (#568)

* Route and actor for record user's agreement to legal terms

* Change order of checks to be safer

* Add 'userAgreed' to ThurloeDAOs and propagate up

* Set userAgreed flag to false while enabling user

* Enroll user only if they agreed to terms

* Remove reference to concrete Google DAO

* Fix HTTP method. Encode email address.

* addUserToBillingProject: Future[Unit] -> Future[Boolean]

* Demote "shouldn't happen" case

* implemented multi-user enable/disable

* fixed race condition

* Add method removeUserFromBillingProject

* Moved the userAgreement endpoint from Trial to Profile and updated Swagger accordingly

* Testing for user agreement endpoint

* Added Thurloe error testing

* Revamp error handling (again)

* Enrollment golden spike

Run Details

135 of 135 new or added lines in 8 files covered. (100.0%)

2243 of 3301 relevant lines covered (67.95%)

0.68 hits per line

New Missed Lines in Diff

Lines	Coverage	File
1	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/dataaccess/HttpGoogleServicesDAO.scala
2	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/model/Trial.scala
8	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/dataaccess/ElasticSearchTrialDAO.scala
12	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/dataaccess/HttpRawlsDAO.scala
20	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/service/TrialService.scala

Uncovered Existing Lines

Lines	Coverage	File
1	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/service/TrialService.scala
1	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/utils/TSVFormatter.scala
1	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/service/LibraryService.scala
1	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/dataaccess/HttpThurloeDAO.scala
1	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/service/StatusService.scala
4	100.0	src/main/scala/org/broadinstitute/dsde/firecloud/model/Profile.scala

Jobs

ID	Job ID	Ran	Files	Coverage
1	3836.1	11 Dec 2017 05:53PM UTC	0	67.95	Travis Job 3836.1

Source Files on build 3836

Detailed source file information is not available for this build.

broadinstitute / firecloud-orchestration / 3836
64%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 3836

broadinstitute / firecloud-orchestration / 3836 64%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 3836

broadinstitute / firecloud-orchestration / 3836
64%

README BADGES
x