1891
90%

Ran 08 Dec 2017 01:24AM UTC

Jobs 1

Files 179

Run time 11s

Badge

Embed ▾

pending completion

Build # 1891

Build Type

Pull #687

travis-ci

Committed by

web-flow

Commit Message

Discard import jobs when the ImportService is the error source

We don't want to retry jobs continuously when an the ActorStack cannot create an
item.

The main reason we expect to get an ImportJob is when our
`ApplicationModelActor` returns `false`, but this also avoids retries on other
`false` states coming out of the actor stack.

Pull Request Pull Request #687: Error out when trying to import existing objects

Run Details

15 of 15 new or added lines in 11 files covered. (100.0%)

1228 of 2925 relevant lines covered (41.98%)

0.91 hits per line

New Missed Lines in Diff

Lines	Coverage	∆	File
1	0.0	0.0%	app/actors/hyrax/actors/audio_actor.rb
1	0.0	0.0%	app/actors/hyrax/actors/ead_actor.rb
1	0.0	-100.0%	app/actors/hyrax/actors/generic_object_actor.rb
1	0.0	-100.0%	app/actors/hyrax/actors/image_actor.rb
1	0.0	-100.0%	app/actors/hyrax/actors/pdf_actor.rb
1	0.0	0.0%	app/actors/hyrax/actors/rcr_actor.rb
1	0.0	0.0%	app/actors/hyrax/actors/tei_actor.rb
1	0.0	0.0%	app/actors/hyrax/actors/video_actor.rb
1	0.0	0.0%	app/actors/hyrax/actors/voting_record_actor.rb
1	38.46	-53.54%	app/services/tufts/import_service.rb
2	50.0		app/actors/application_model_actor.rb

Uncovered Existing Lines

Lines	Coverage	∆	File
1	73.33	-6.67%	app/forms/hyrax/audio_form.rb
1	69.23	-7.69%	app/forms/hyrax/ead_form.rb
1	69.23	-7.69%	app/forms/hyrax/image_form.rb
1	69.23	-7.69%	app/forms/hyrax/rcr_form.rb
1	69.23	-7.69%	app/forms/hyrax/tei_form.rb
1	73.33	-6.67%	app/forms/hyrax/video_form.rb
1	69.23	-7.69%	app/forms/hyrax/voting_record_form.rb
1	66.67	-16.67%	app/helpers/tufts/tufts_helper_behavior.rb
1	50.0	-16.67%	app/jobs/import_job.rb
1	66.67	-33.33%	app/jobs/metadata_import_job.rb
1	80.0	-20.0%	app/presenters/hyrax/generic_work_presenter.rb
2	50.0	-50.0%	app/jobs/publish_job.rb
2	50.0	-50.0%	app/jobs/unpublish_job.rb
2	75.0	-25.0%	app/lib/tufts/metadata_file_uploader.rb
2	92.59	-7.41%	app/lib/tufts/workflow_setup.rb
2	0.0	-100.0%	app/models/forms/generic_deposit.rb
2	0.0	-100.0%	app/models/handle_log.rb
2	60.0	-40.0%	app/renderers/resource_type_renderer.rb
3	57.14	-42.86%	app/controllers/tufts/handle_log_controller.rb
3	57.14	-42.86%	app/forms/tufts/has_transcript_form.rb
3	66.67	-33.33%	app/lib/tufts/handle_builder.rb
3	66.67	-33.33%	app/lib/tufts/null_change_set.rb
3	78.57	-21.43%	app/models/deposit_type.rb
3	70.0	-30.0%	app/search_builders/tufts_catalog_search_builder.rb
3	66.67	-33.33%	app/services/hyrax/workflow/comment_notification.rb
3	66.67	-33.33%	app/services/hyrax/workflow/published_notification.rb
3	66.67	-33.33%	app/services/hyrax/workflow/self_deposit_notification.rb
3	66.67	-33.33%	app/services/hyrax/workflow/unpublished_notification.rb
3	66.67	-33.33%	app/services/tufts/displays_in_service.rb
3	66.67	-33.33%	app/services/tufts/handle_log_service.rb
3	50.0	-50.0%	app/services/tufts/metadata_service.rb
4	69.23	-30.77%	app/forms/hyrax/generic_object_form.rb
4	69.23	-30.77%	app/forms/hyrax/pdf_form.rb
4	76.47	-23.53%	app/forms/hyrax/template_form.rb
4	91.49	-8.51%	app/models/concerns/tufts/metadata/adminstrative.rb
4	63.64	-36.36%	app/services/tufts/resource_type_service.rb
4	75.0	-25.0%	app/controllers/application_controller.rb
5	44.44	-55.56%	app/controllers/tufts/drafts/editable.rb
5	50.0	-50.0%	app/controllers/tufts/qr_status_controller.rb
5	31.25	-15.63%	app/helpers/contribute_helper.rb
5	58.33	-41.67%	app/lib/tufts/job_item_store.rb
5	61.54	-38.46%	app/models/batch_task.rb
5	66.67	-33.33%	app/presenters/metadata_export_presenter.rb
5	54.55	-45.45%	app/services/tufts/metadata_import_service.rb
5	0.0	-100.0%	app/actors/hyrax/actors/generic_object_actor.rb
5	0.0	-100.0%	app/actors/hyrax/actors/image_actor.rb
5	0.0	-100.0%	app/actors/hyrax/actors/pdf_actor.rb
6	52.94	-35.29%	app/lib/tufts/handle_dispatcher.rb
6	0.0	-100.0%	app/models/forms/undergrad_summer_scholar.rb
6	62.5	-37.5%	app/models/metadata_import.rb
6	53.33	-40.0%	app/services/hyrax/workflow/mira_notification.rb
7	33.33	-46.67%	app/controllers/hyrax/metadata_imports_controller.rb
7	58.82	-41.18%	app/controllers/tufts/works_controller.rb
7	65.0	-35.0%	app/lib/tufts/changeset_application_strategy.rb
7	50.0	-50.0%	app/lib/tufts/draftable.rb
7	19.05	-16.67%	app/lib/tufts/technical_metadata.rb
7	50.0	-50.0%	app/models/metadata_export.rb
7	61.11	-38.89%	app/models/template_update.rb
8	38.46	-61.54%	app/models/ability.rb
8	0.0	-100.0%	app/search_builders/tufts_my_works_search_builder.rb
8	46.67	-53.33%	app/actors/hyrax/actors/handle_assurance_actor.rb
9	0.0	-100.0%	app/controllers/hyrax/generic_objects_controller.rb
9	0.0	-100.0%	app/controllers/hyrax/images_controller.rb
9	0.0	-100.0%	app/controllers/hyrax/rcrs_controller.rb
9	0.0	-100.0%	app/controllers/hyrax/teis_controller.rb
9	33.33	-50.0%	app/controllers/hyrax/template_updates_controller.rb
9	0.0	-100.0%	app/controllers/hyrax/videos_controller.rb
9	0.0	-100.0%	app/controllers/hyrax/voting_records_controller.rb
9	47.06	-52.94%	app/services/hyrax/workflow/template_notification.rb
10	47.62	-47.62%	app/controllers/hyrax/batches_controller.rb
10	28.57	-71.43%	app/controllers/hyrax/metadata_exports_controller.rb
11	38.89	-61.11%	app/controllers/tufts/publication_status_controller.rb
11	31.58	-57.89%	app/lib/tufts/changeset_overwrite_strategy.rb
11	52.0	-44.0%	app/models/user.rb
13	0.0	-87.5%	app/models/forms/cummings_thesis.rb
13	48.65	-35.14%	app/presenters/xml_import_presenter.rb
13	38.46	-53.54%	app/services/tufts/import_service.rb
14	44.83	-48.28%	app/controllers/deposit_types_controller.rb
14	39.13	-60.87%	app/lib/tufts/mira_xml_importer.rb
14	48.39	-45.16%	app/presenters/batch_presenter.rb
15	33.33	-62.5%	app/lib/import_export/deposit_type_exporter.rb
15	26.09	-65.22%	app/lib/tufts/changeset_preserve_strategy.rb
15	0.0	-90.0%	app/models/forms/faculty_scholarship.rb
15	0.0	-87.5%	app/models/forms/qualifying_paper.rb
16	42.86	-57.14%	app/lib/tufts/mira_xml_mapping.rb
17	37.04	-62.96%	app/controllers/tufts/draft_controller.rb
17	45.16	-54.84%	app/lib/tufts/metadata_exporter.rb
18	28.57	-64.29%	app/lib/tufts/normalizer.rb
19	40.63	-59.38%	app/lib/import_export/deposit_type_importer.rb
19	38.71	-61.29%	app/lib/tufts/workflow_status.rb
19	51.28	-48.72%	app/models/batch.rb
19	36.67	-63.33%	app/controllers/contribute_controller.rb
21	54.17	-43.75%	app/lib/tufts/importer.rb
23	30.3	-69.7%	app/controllers/hyrax/templates_controller.rb
23	0.0	-93.33%	app/models/forms/capstone_project.rb
23	0.0	-72.73%	app/renderers/tufts_rights_statement_attribute_renderer.rb
24	40.0	-60.0%	app/lib/tufts/draft.rb
27	0.0	-88.89%	app/models/forms/honors_thesis.rb
28	20.0	-80.0%	app/lib/tufts/xml_metadata_builder.rb
28	0.0	-94.44%	app/models/forms/public_health.rb
29	31.82	-65.91%	app/lib/tufts/handle_registrar.rb
30	21.05	-78.95%	app/helpers/gis_helper.rb
32	38.46	-61.54%	app/lib/tufts/template.rb
35	28.85	-67.31%	app/controllers/hyrax/xml_imports_controller.rb
38	0.0	-94.74%	app/controllers/hyrax/my/works_controller.rb
39	0.0	-100.0%	app/models/forms/generic_tisch_deposit.rb
41	0.0	-94.12%	app/models/solr_document.rb
45	29.23	-69.23%	app/lib/tufts/import_record.rb
46	36.99	-63.01%	app/models/xml_import.rb
49	0.0	-88.46%	app/models/forms/gis_poster.rb
87	0.0	-100.0%	app/lib/tufts/changeset_serializer.rb
108	0.0	-95.16%	app/models/forms/contribution.rb

Jobs

ID	Job ID	Ran	Files	Coverage
1	1891.1 (2.3.4)	08 Dec 2017 01:24AM UTC	179	41.98	Travis Job 1891.1

Source Files on build 1891

Coverage	∆	File	Lines	Relevant	Covered	Missed	Hits/Line

curationexperts / epigaea / 1891
90%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 1891

curationexperts / epigaea / 1891 90%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

New Missed Lines in Diff

Uncovered Existing Lines

Jobs

Source Files on build 1891

curationexperts / epigaea / 1891
90%

README BADGES
x